add test for async-sync function invocation handler #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed logging level from info to debug in RegularRequestHandler for improved log granularity. - Refactored `_async_inject_context` in base.py to streamline context injection for async functions. - Introduced `_handle_async_function` to manage the invocation of async and sync functions, improving code clarity. - Added tests for `_handle_async_function` and `_async_inject_context` to ensure correct behavior and context handling.
aniketmaurya
requested review from
Borda,
KaelanDt,
andyland,
ethanwharris,
justusschock,
k223kim,
lantiga and
tchaton
as code owners
- Introduced a new test file `test_async.py` to validate the behavior of an asynchronous API using the LitServe framework. - Implemented a minimal async API class and a corresponding test case to ensure correct prediction output for async requests. - Utilized pytest and httpx for testing the async functionality, ensuring proper handling of requests and responses.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
===================================
Coverage 85% 85%
===================================
Files 38 38
Lines 2940 2942 +2
===================================
+ Hits 2504 2510 +6
+ Misses 436 432 -4 🚀 New features to boost your workflow:
|
k223kim
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Users can run async API with minimal code:
_handle_async_functionto manage the invocation of async and sync functions, improving code clarity._handle_async_functionand_async_inject_contextto ensure correct behavior and context handling.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃